citrusframework / citrus

Framework for automated integration tests with focus on messaging integration
https://citrusframework.org
Apache License 2.0
456 stars 134 forks source link

dependency updates #1141

Closed bbortt closed 5 months ago

bbortt commented 5 months ago

closes #1139.

bbortt commented 5 months ago

@christophd there is a problem with the jetty upgrade, it is now more sensitive to non-existing resource paths, it seems. I've managed to work around this with a retry, based on the assumption that src/main/resources will be packed into target/classes.

more information and documentation is also available on commit 680b77ff1be6d489c2c01b07af45662e3fc6fc2f.

I've only employed the fix for citrus-http and await your opinion/review before applying it to citrus-ws too.

christophd commented 5 months ago

@bbortt if this workaround fixes the issue I am totally fine with it.

In general, I wonder though why we do set this resource base to a default value src/main/resources. I think setting this resource base path is not mandatory for the Jetty server. So we could change this to a new default value null so the user still has the opportunity to customize this resource base but it will not be set by default. Then we would not need that retry mechanism as throwing an exception when the user sets an invalid resource base would be Ok. WDYT?

bbortt commented 5 months ago

I wonder though why we do set this resource base to a default value src/main/resources

I wasn't aware of the history, that's why I thought to keep it. of course, it's much simpler to just remove the default. I will push an updated later on.