search

citrusframework / citrus

Framework for automated integration tests with focus on messaging integration
https://citrusframework.org
Apache License 2.0
445 stars 135 forks source link

fix(#948): Log proper test step index on incremental Citrus tests #1151

Closed turing85 closed 2 months ago

turing85 commented 2 months ago

Avoid all test steps to be reported as "TEST STEP 0" for incremental tests

(cherry picked from commit 21aeb4385587cae7a35911a517f41b372189d53d)

turing85 commented 2 months ago

@christophd It would be nice if we could produce a 3.x release with this fix.

bbortt commented 2 months ago

it's hard to imagine what's happening currently and what should happen, with just this change being present. please add a test that proves the desired behavior.

turing85 commented 2 months ago

it's hard to imagine what's happening currently and what should happen, with just this change being present. please add a test that proves the desired behavior.

This is just a cherry-pick from a commit that is already on main...

bbortt commented 2 months ago

hmm, I see. sorry, didn't read the description to the end.

bbortt commented 2 months ago

would you mind cherry-pick'ing it upon the updated base?

we're planning to release the backport of https://github.com/citrusframework/citrus/pull/1148 soon. we could easily include this PR as well.

turing85 commented 2 months ago

would you mind cherry-pick'ing it upon the updated base?

we're planning to release the backport of #1148 soon. we could easily include this PR as well.

@bbortt here you are.

turing85 commented 2 months ago

Reopened and set base back to 3.x. See https://github.com/citrusframework/citrus/pull/1152#issuecomment-2074444403

bbortt commented 2 months ago

I am so sorry @turing85 .. I didn't know what branch @christophd uses and had already done https://github.com/citrusframework/citrus/pull/1148 into support/3.0.0. totally my bad! thanks for the contribution ❤️