citrusframework / citrus

Framework for automated integration tests with focus on messaging integration
https://citrusframework.org
Apache License 2.0
460 stars 137 forks source link

remove code smells #1220

Closed bbortt closed 1 month ago

bbortt commented 1 month ago

removed some code "smells"...

additionally:

bbortt commented 1 month ago

ok, sorry. this requires some more work.

bbortt commented 1 month ago

@christophd can you please check that I did allright in the second commit? I think the first is less critical. thanks for the review!

bbortt commented 1 month ago

@christophd I've rebased it and fixed the merge conflicts.

christophd commented 1 month ago

CI job is flaky. I'll have a look

bbortt commented 1 month ago

@christophd let me know if you've fixed it. https://github.com/citrusframework/citrus/pull/1232 would be a good addition to the next release as well.