citrusframework / citrus

Framework for automated integration tests with focus on messaging integration
https://citrusframework.org
Apache License 2.0
460 stars 137 forks source link

fix: disallow access into ws interceptors #1237

Closed bbortt closed 1 month ago

bbortt commented 1 month ago

problem; access to interceptors list is exposed to public. modifications to it won't be propagated to the underlying web service template.

I personally find this a bit irritating. I think the acessor methods could be used instead, that's what this PR would change.

see this (unchanged) setter implementation:

    public void setInterceptors(List<ClientInterceptor> interceptors) {
        this.interceptors = interceptors;
        getWebServiceTemplate().setInterceptors(interceptors.toArray(new ClientInterceptor[0]));
    }
christophd commented 1 month ago

could you please elaborate why this has been an issue, thx

bbortt commented 1 month ago

could you please elaborate why this has been an issue, thx

@christophd updated the PR description.