search

citruspi / RHoKTheHood

A system for visualizing census data over the City of Rochester.
https://rhokthehood.com
MIT License
4 stars 2 forks source link

Close filter menu on filter selection #11

Open dubilla opened 10 years ago

dubilla commented 10 years ago

Idea discussed off-thread to get around potential mobile issue with Foundation: when the filter flyout button is clicked, close the original menu. Then, when a filter is selected in mobile, we should be able to just close the flyout menu, without worrying about the original menu.

thequbit commented 10 years ago

I think the filter menu should close no matter what. When clicking on a block after clicking the menu, the click does not register and it needs to be clicked again. If the flow is:

> Click Filter Menu
> Click Desired Filter
> Close Filter Menu
> Click Block Group
> Display Block Group Info in Pop-Up
> repeat.
citruspi commented 10 years ago

@thequbit,

Not necessarily. I understand what you mean when you say that

When clicking on a block after clicking the menu, the click does not register and it needs to be clicked again

I believe that the problem lies in the fact that the map element doesn't have focus when the sidebar is open - the sidebar does. So it's "logical" for the user to click on the map, giving it focus and exiting the sidebar, and then select the block. Normally the sidebar is used for navigating to other pages/views and so the focus doesn't matter because a new page is loaded in that event.

As for

I think the filter menu should close no matter what.

I'm not sure if I agree with that. There have been times when I accidentally selected the wrong filter. If the sidebar closed every time a filter was selected, it could be a frustrating experience for the user to have to reopen the sidebar, scroll down to the filter, and select it. It would be even worse on mobile devices where they would have to open an extra menu.

— @citruspi