search

citruspi / RHoKTheHood

A system for visualizing census data over the City of Rochester.
https://rhokthehood.com
MIT License
4 stars 2 forks source link

Missing .travis.yml #24

Open Nolski opened 9 years ago

Nolski commented 9 years ago

Travis build is failing because it's missing .travis.yml.

citruspi commented 9 years ago

@Nolski,

Err, how do we go about this?

I'm not a JavaScript hacker, so I'm curious as to how people perform Continuous Integration with front end JavaScript. Is it just a test with a headless browser to make sure there are no JavaScript errors on load and that all the code we use performs similarly across different browsers?

I'm just curious as to what direction we're going to take this in.

— @citruspi

thequbit commented 9 years ago

I too am interested :).

Tim Duffy http://timduffy.me/ 585-210-8353 @arbiterofbits On Jan 16, 2015 2:59 PM, "Mihir Singh" notifications@github.com wrote:

@Nolski https://github.com/Nolski,

Err, how do we go about this?

I'm not a JavaScript hacker, so I'm curious as to how people perform Continuous Integration with front end JavaScript. Is it just a test with a headless browser to make sure there are no JavaScript errors on load and that all the code we use performs similarly across different browsers?

I'm just curious as to what direction we're going to take this in.

— @citruspi https://github.com/citruspi

— Reply to this email directly or view it on GitHub https://github.com/citruspi/RHoKTheHood/issues/24#issuecomment-70312995.

Nolski commented 9 years ago

So there are multiple levels to take this on (I thought we already had travis setup partly on RHoK The Hood which is why I made this issue but now it looks otherwise... huh).

First is to just setup the make file to do npm install, bower install, etc and then run gulp to compile all of our stuff and make sure everything at least builds correctly.

Next is to setup jshint and have a .jshint_rc in the repo to make sure you have valid javascript.

Lastly you can run unit tests using karma and jasmine which is what I am starting to do in yellr-server. You actually can just run tests in firefox and start the the browser in travis using this little trick that I found

And then you have a nice maintainable javascript code base (crazy right?).

citruspi commented 9 years ago

@Nolski,

First is to just setup the make file to do npm install, bower install, etc and then run gulp to compile all of our stuff and make sure everything at least builds correctly.

So, for what it's worth, the Makefile in the repository has supported that since October.

Having said that, we now have a .travis.yml file. So, Travis CI continues to fail but it's now because we have invalid JavaScript, not because we don't have Travis CI configured.

— @citruspi