citusdata / citus

Distributed PostgreSQL as an extension
https://www.citusdata.com
GNU Affero General Public License v3.0
10.43k stars 662 forks source link

incorrect error message when setting citus.distributed_deadlock_detection_factor #1783

Open mtuncer opened 6 years ago

mtuncer commented 6 years ago
alter system set citus.distributed_deadlock_detection_factor = 1;
WARNING:  citus.distributed_deadlock_detection_factor cannot be less than 1. To disable distributed deadlock detection set the value to -1.
ERROR:  invalid value for parameter "citus.distributed_deadlock_detection_factor": 1

I was clearly not setting it to a value less than 1. Setting it to 1.000001 works.

onderkalaci commented 6 years ago

cannot be less than 1

should be

cannot be less than or equal to 1 which we can live with I guess.

mtuncer commented 6 years ago

should be greater than 1 perhaps

jasonmp85 commented 6 years ago

Additional note: the set it to -1 to disable directly contradicts the previous claim (that it must be greater than 1).