Open aytekinar opened 1 year ago
I would also add that description of the block_writes
shard transfer mode is incorrect: it states
Use COPY (blocking writes) for tables lacking primary key or replica identity.
While in reality it uses COPY and blocks writes for all tables in question, as can be seen here
Actual Behavior
The documentation has misleading information regarding the argument set of
citus_rebalance_start
, i.e., it lists the argumentsthreshold
,drain_only
andrebalance_strategy
as opposed to the actual argument setrebalance_strategy
,drain_only
andshard_transfer_mode
, in the given order.Desired Behavior
We should copy over the documentation regarding
shard_transfer_mode
from d1ff979, if the functionality has not changed, to the arguments ofcitus_rebalance_start
and remove the non-existingthreshold
from the docs.I can create a PR if desired.
/cc @begriffs, @jonels-msft.