citusdata / django-multitenant

Python/Django support for distributed multi-tenant databases like Postgres+Citus
MIT License
721 stars 119 forks source link

Does this library restrict the version of Django? #1

Closed begriffs closed 6 years ago

begriffs commented 7 years ago

I added django_multitenant to the requirements.txt on an existing Django 1.11 project. However running pip install -r requirements.txt then uninstalls Django and downgrades it to 1.10:

Installing collected packages: Django, django-multitenant
  Found existing installation: Django 1.11
    Uninstalling Django-1.11:
      Successfully uninstalled Django-1.11
  Running setup.py install for django-multitenant ... done
Successfully installed Django-1.10 django-multitenant-0.3

Not sure if the dependencies of this library caused that to happen, and recording an issue just in case.

saicitus commented 6 years ago

@jasonmp85 Any thoughts on why the above is happening. Could it be because of the find_packages() in the setup.py

jasonmp85 commented 6 years ago

Gah, I swore we debugged and figured this out a while back; I don't remember anymore, though…

saicitus commented 6 years ago

Hey @begriffs, just FYI, I tested this with the latest library release and couldn't reproduce this issue.

#Did this with django 1.11 already installed.
pip install django-multitenant
Collecting django-multitenant
Installing collected packages: django-multitenant
Successfully installed django-multitenant-1.0.1

Could it be because of your apps requirements.txt rather than the django-multitenant library restricting the django version?

saicitus commented 6 years ago

Tested and hence closing the issue.