search

citusdata / django-multitenant

Python/Django support for distributed multi-tenant databases like Postgres+Citus
MIT License
710 stars 116 forks source link

Strict mode #118

Closed hen-ps closed 2 years ago

hen-ps commented 2 years ago

Hi, I added some changes to raise exceptions instead of warning when no tenant is provided.

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

s4ke commented 2 years ago

Not the maintainer of this project, but I think the settings var should be prefixed with DJANGO_MULTITENANT or something along these lines as it will pollute the namespace of all apps that use it.

hen-ps commented 2 years ago

Not the maintainer of this project, but I think the settings var should be prefixed with DJANGO_MULTITENANT or something along these lines as it will pollute the namespace of all apps that use it.

thanks for the suggestion, I added the prefix :)

hen-ps commented 2 years ago

If it's easy to add a test for this, could you add one?

sorry I was busy at work, I see you merged it. thanks. I'll add another PR with another feature and tests for this one in the coming days :)

JelteF commented 2 years ago

No worries, thanks for the contribution. I'm looking forward to the PR with the tests.