Closed gurkanindibay closed 1 year ago
Another note, looks like this PR is related to https://github.com/citusdata/django-multitenant/pull/132 which you previously approved. Are we able to close that one now in favor of this one?
Another note, looks like this PR is related to #132 which you previously approved. Are we able to close that one now in favor of this one?
Fixed that one as well
Merging #142 (9251bdb) into main (4e5b372) will increase coverage by
0.09%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #142 +/- ##
==========================================
+ Coverage 97.91% 98.01% +0.09%
==========================================
Files 32 32
Lines 1006 1006
==========================================
+ Hits 985 986 +1
+ Misses 21 20 -1
Impacted Files | Coverage Δ | |
---|---|---|
...go_multitenant/tests/migrations/0002_distribute.py | 100.00% <ø> (ø) |
|
django_multitenant/tests/settings.py | 100.00% <0.00%> (+5.55%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
One little thing then good to go
Edit: can you also double check whether the instructions in CONTRIBUTING.md are still up to date? It talks about how to run tests and format the code.
Yes it's up-to-date
Currently, our support matrix does not include Citus versions. When I add Citus version, I needed to parametrise tox testing framework scripts. However, I can not execute docker-compose to execute in tox framework. Additionally after adding additional django versions, test durations reached to nearly 15 minutes. Therefore, I removed tox and execute all tests under GitHub Actions To run the tests in various python environments, I needed a docker image, which includes all the required python versions To keep the image up-to-date, I added a pipeline to bake this image as well Now, we have full-fledged understandable and extendable test environment