search

citusdata / django-multitenant

Python/Django support for distributed multi-tenant databases like Postgres+Citus
MIT License
708 stars 116 forks source link

Fixes missing installation instructions #147

Closed gurkanindibay closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #147 (ceeaa95) into main (d57f86f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files          32       32           
  Lines        1006     1006           
=======================================
  Hits          986      986           
  Misses         20       20

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

gurkanindibay commented 1 year ago

which the python version are you using?

jonels-msft commented 1 year ago

which the python version are you using?

Good point, let me be more methodical.

My environment

$ git rev-parse HEAD
1d9aad4ac72b0b4b20f974a6f1e7895d2245f19f

$ python --version
Python 3.10.8

$ python -m venv .venv
$ . .venv/bin/activate

$ pip --version
pip 22.2.2 from /Users/jonels/dev/django-multitenant/.venv/lib/python3.10/site-packages/pip (python 3.10)

Running make test-dependencies

$ DJANGO_VERSION=4.1
$ CITUS_VERSION=11.2
$ make test-dependencies
pip install -r requirements/test-requirements.txt
Collecting attrs==22.2.0
  Using cached attrs-22.2.0-py3-none-any.whl (60 kB)
Collecting coverage[toml]==7.0.5
  Downloading coverage-7.0.5-cp310-cp310-macosx_10_9_x86_64.whl (197 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 197.9/197.9 kB 4.1 MB/s eta 0:00:00
Collecting exam==0.10.6
  Downloading exam-0.10.6.tar.gz (15 kB)
  Preparing metadata (setup.py) ... done
Collecting exceptiongroup==1.1.0
  Downloading exceptiongroup-1.1.0-py3-none-any.whl (14 kB)
Collecting iniconfig==2.0.0
  Downloading iniconfig-2.0.0-py3-none-any.whl (5.9 kB)
Collecting mock==5.0.1
  Downloading mock-5.0.1-py3-none-any.whl (30 kB)
Collecting packaging==23.0
  Using cached packaging-23.0-py3-none-any.whl (42 kB)
Collecting pluggy==1.0.0
  Downloading pluggy-1.0.0-py2.py3-none-any.whl (13 kB)
Collecting psycopg2-binary==2.9.5
  Downloading psycopg2_binary-2.9.5-cp310-cp310-macosx_10_15_x86_64.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl (2.2 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.2/2.2 MB 35.4 MB/s eta 0:00:00
Collecting pytest==7.2.0
  Downloading pytest-7.2.0-py3-none-any.whl (316 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 316.8/316.8 kB 11.2 MB/s eta 0:00:00
Collecting pytest-cov==4.0.0
  Downloading pytest_cov-4.0.0-py3-none-any.whl (21 kB)
Collecting pytest-django==4.5.2
  Downloading pytest_django-4.5.2-py3-none-any.whl (20 kB)
Collecting tomli==2.0.1
  Downloading tomli-2.0.1-py3-none-any.whl (12 kB)
Using legacy 'setup.py install' for exam, since package 'wheel' is not installed.
Installing collected packages: tomli, psycopg2-binary, pluggy, packaging, mock, iniconfig, exceptiongroup, coverage, attrs, pytest, exam, pytest-django, pytest-cov
  Running setup.py install for exam ... done
Successfully installed attrs-22.2.0 coverage-7.0.5 exam-0.10.6 exceptiongroup-1.1.0 iniconfig-2.0.0 mock-5.0.1 packaging-23.0 pluggy-1.0.0 psycopg2-binary-2.9.5 pytest-7.2.0 pytest-cov-4.0.0 pytest-django-4.5.2 tomli-2.0.1

[notice] A new release of pip available: 22.2.2 -> 23.0.1
[notice] To update, run: pip install --upgrade pip
pip install Django==""
ERROR: Could not find a version that satisfies the requirement Django== (from versions: 1.1.3, 1.1.4, 1.2, 1.2.1, 1.2.2, 1.2.3, 1.2.4, 1.2.5, 1.2.6, 1.2.7, 1.3, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.3.6, 1.3.7, 1.4, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6, 1.4.7, 1.4.8, 1.4.9, 1.4.10, 1.4.11, 1.4.12, 1.4.13, 1.4.14, 1.4.15, 1.4.16, 1.4.17, 1.4.18, 1.4.19, 1.4.20, 1.4.21, 1.4.22, 1.5, 1.5.1, 1.5.2, 1.5.3, 1.5.4, 1.5.5, 1.5.6, 1.5.7, 1.5.8, 1.5.9, 1.5.10, 1.5.11, 1.5.12, 1.6, 1.6.1, 1.6.2, 1.6.3, 1.6.4, 1.6.5, 1.6.6, 1.6.7, 1.6.8, 1.6.9, 1.6.10, 1.6.11, 1.7, 1.7.1, 1.7.2, 1.7.3, 1.7.4, 1.7.5, 1.7.6, 1.7.7, 1.7.8, 1.7.9, 1.7.10, 1.7.11, 1.8a1, 1.8b1, 1.8b2, 1.8rc1, 1.8, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.8.5, 1.8.6, 1.8.7, 1.8.8, 1.8.9, 1.8.10, 1.8.11, 1.8.12, 1.8.13, 1.8.14, 1.8.15, 1.8.16, 1.8.17, 1.8.18, 1.8.19, 1.9a1, 1.9b1, 1.9rc1, 1.9rc2, 1.9, 1.9.1, 1.9.2, 1.9.3, 1.9.4, 1.9.5, 1.9.6, 1.9.7, 1.9.8, 1.9.9, 1.9.10, 1.9.11, 1.9.12, 1.9.13, 1.10a1, 1.10b1, 1.10rc1, 1.10, 1.10.1, 1.10.2, 1.10.3, 1.10.4, 1.10.5, 1.10.6, 1.10.7, 1.10.8, 1.11a1, 1.11b1, 1.11rc1, 1.11, 1.11.1, 1.11.2, 1.11.3, 1.11.4, 1.11.5, 1.11.6, 1.11.7, 1.11.8, 1.11.9, 1.11.10, 1.11.11, 1.11.12, 1.11.13, 1.11.14, 1.11.15, 1.11.16, 1.11.17, 1.11.18, 1.11.20, 1.11.21, 1.11.22, 1.11.23, 1.11.24, 1.11.25, 1.11.26, 1.11.27, 1.11.28, 1.11.29, 2.0a1, 2.0b1, 2.0rc1, 2.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4, 2.0.5, 2.0.6, 2.0.7, 2.0.8, 2.0.9, 2.0.10, 2.0.12, 2.0.13, 2.1a1, 2.1b1, 2.1rc1, 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.1.5, 2.1.7, 2.1.8, 2.1.9, 2.1.10, 2.1.11, 2.1.12, 2.1.13, 2.1.14, 2.1.15, 2.2a1, 2.2b1, 2.2rc1, 2.2, 2.2.1, 2.2.2, 2.2.3, 2.2.4, 2.2.5, 2.2.6, 2.2.7, 2.2.8, 2.2.9, 2.2.10, 2.2.11, 2.2.12, 2.2.13, 2.2.14, 2.2.15, 2.2.16, 2.2.17, 2.2.18, 2.2.19, 2.2.20, 2.2.21, 2.2.22, 2.2.23, 2.2.24, 2.2.25, 2.2.26, 2.2.27, 2.2.28, 3.0a1, 3.0b1, 3.0rc1, 3.0, 3.0.1, 3.0.2, 3.0.3, 3.0.4, 3.0.5, 3.0.6, 3.0.7, 3.0.8, 3.0.9, 3.0.10, 3.0.11, 3.0.12, 3.0.13, 3.0.14, 3.1a1, 3.1b1, 3.1rc1, 3.1, 3.1.1, 3.1.2, 3.1.3, 3.1.4, 3.1.5, 3.1.6, 3.1.7, 3.1.8, 3.1.9, 3.1.10, 3.1.11, 3.1.12, 3.1.13, 3.1.14, 3.2a1, 3.2b1, 3.2rc1, 3.2, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.5, 3.2.6, 3.2.7, 3.2.8, 3.2.9, 3.2.10, 3.2.11, 3.2.12, 3.2.13, 3.2.14, 3.2.15, 3.2.16, 3.2.17, 3.2.18, 4.0a1, 4.0b1, 4.0rc1, 4.0, 4.0.1, 4.0.2, 4.0.3, 4.0.4, 4.0.5, 4.0.6, 4.0.7, 4.0.8, 4.0.9, 4.0.10, 4.1a1, 4.1b1, 4.1rc1, 4.1, 4.1.1, 4.1.2, 4.1.3, 4.1.4, 4.1.5, 4.1.6, 4.1.7, 4.2a1, 4.2b1)
ERROR: No matching distribution found for Django==

[notice] A new release of pip available: 22.2.2 -> 23.0.1
[notice] To update, run: pip install --upgrade pip
make: *** [test-dependencies] Error 1
jonels-msft commented 1 year ago

Looks like the way I set the environment variable wasn't passed from my shell to the Makefile. We could simplify the command and make it more portable like this:

make test-dependencies DJANGO_VERSION=4.1 CITUS_VERSION=11.2
gurkanindibay commented 1 year ago

Fixed and tested. Now it works. Thanks for the test and pointing out the issue :)