search

citusdata / django-multitenant

Python/Django support for distributed multi-tenant databases like Postgres+Citus
MIT License
707 stars 116 forks source link

Release 4.1.0 overwrote 4.0.0 wheel #205

Closed hrother closed 6 months ago

hrother commented 6 months ago

It looks like the publication of the 4.1.0 release overwrote the 4.0.0 wheels on pypi.

image

The broken 4.0.0 wheel now produces this error:

AttributeError: 'Settings' object has no attribute 'TENANT_USE_ASGIREF'

The asgiref support should not be part of 4.0.0 but only of 4.1.0.

rzwink commented 6 months ago

We needed to add TENANT_USE_ASGIREF = False to our applications settings.py to avoid an error we were getting after the happened. FYI.

hrother commented 6 months ago

Yes that's how we hot fixed the error too.

hrother commented 6 months ago

I'm sorry but I do not think this issue is fixed yet.

The 4.0.0 wheel on pypi still contains the source code of the 4.1.0 release.

Therefore all django applications which have pinned django-multitenant to 4.0.0 will break when they are reinstalled/redeployed.

@gurkanindibay is it possible to recreate the 4.0.0 wheel and upload it to pypi?