citusdata / django-multitenant

Python/Django support for distributed multi-tenant databases like Postgres+Citus
MIT License
707 stars 116 forks source link

Fix utils to not require `TENANT_USE_ASGIREF` to be defined in the host django project #206

Closed ekampf closed 6 months ago

ekampf commented 6 months ago

Most projects using django-multitenant wont have TENANT_USE_ASGIREF defined as its a new feature. They also shouldnt be required to add it... should just be treated as False if missing.

This is an issue that was introduced by #198

Note that this will also resolve #205 issues

ekampf commented 6 months ago

FYI @gurkanindibay this is an issue thats breaking everyone installing the new 4.1.0

gurkanindibay commented 6 months ago

FYI @gurkanindibay this is an issue thats breaking everyone installing the new 4.1.0

@ekampf Thanks for the heads up. I'm checking

gurkanindibay commented 6 months ago

@ekampf could you check the errors

Thanks

ekampf commented 6 months ago

@microsoft-github-policy-service agree

ekampf commented 6 months ago

@microsoft-github-policy-service agree company="twingate"

ekampf commented 6 months ago

@gurkanindibay tests fixed

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (30e3238) 100.00% compared to head (42cef30) 100.00%. Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #206 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 44 44 Lines 1193 1240 +47 ========================================= + Hits 1193 1240 +47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gurkanindibay commented 6 months ago

@ekampf I released v4.1.1 with your PR. Could you check? Thanks

ekampf commented 6 months ago

@gurkanindibay thanks! confirming it works

gurkanindibay commented 6 months ago

@ekampf thanks for your contribution.