search

citusdata / django-multitenant

Python/Django support for distributed multi-tenant databases like Postgres+Citus
MIT License
731 stars 118 forks source link

Incorrect guidance in docs #80

Closed rob101 closed 4 years ago

rob101 commented 4 years ago

In the docs, the following is suggested:

     def process_response(self, request, response):
             set_current_tenant(None)
             return response

This means that the response has no tenant when returned, incapacitating the project. Presumably this should be removed? It is also now depreciated and would require django.utils.deprecation.MiddlewareMixin

louiseGrandjonc commented 4 years ago

Yes, you are right, this should be removed from the documentation.

louiseGrandjonc commented 4 years ago

Fixed in https://github.com/citusdata/django-multitenant/commit/1c908cb6fe18f83df07bf1441411cfe37fb20295