search

citusdata / docker

:ship: Docker images and configuration for Citus
Apache License 2.0
241 stars 100 forks source link

Fixes for Update docker files pipeline integration #251

Closed gurkanindibay closed 3 years ago

gurkanindibay commented 3 years ago

There were some problems while executing "Update version on Docker files" Problems fixed are as below

  1. pipeline flag is added in update_docker script (tools issue 147). This flag is integrated into this pipeline
  2. update_docker script needs git email and name configuration. This was added as step
  3. environment parameters were used instead of input parameters in python command to remove the secret leakage risk (GH_TOKEN) and to be able to handle null parameters ( POSTGRES_VERSION)

Before merging this PR , tools PR 148 should be merged. After merging PR 148, I will change 

git clone -b issue_147 --depth=1 https://github.com/citusdata/tools.git tools into

into

git clone -b develop --depth=1 https://github.com/citusdata/tools.git tools into