citusdata / docker

:ship: Docker images and configuration for Citus
Apache License 2.0
239 stars 100 forks source link

docker stack deploy compatible #70

Open blaggacao opened 6 years ago

blaggacao commented 6 years ago

docker stack deploy (soon to be integrated with kubernetes or using kompose) is not compatible with container_name, I just commented it out but it is not clear from the outside if this was just cosmetics or if it's required for the functioning of this compose file.

If cosmetics, could you drop it?

arruw commented 6 years ago

+1

arruw commented 6 years ago

@blaggacao Did you managed to deploy it to Docker Swarm?

blaggacao commented 6 years ago

@matjazmav I'm currently waiting for some upstream upgrades (basically GA of Rancher 2.0) so to shift all infrastructure to k8s. Untill then I unfortunately do not have much time to invest further in this..

Kelvinrr commented 6 years ago

I have a working compose file tested on our local cluster: https://github.com/Kelvinrr/docker-postgis-citus/blob/master/docker-compose.yml

From my experience, name doesn't matter, although someone correct if otherwise. Most of the problems in running on swarm was the manager. I worked around the issues in the compose file:

Overall, I think the solution for docker stack compatibility is a update to https://github.com/citusdata/membership-manager

Alternatively, workers can be added manually and circumvent manager.py entirely.

xirius commented 4 years ago

Still no progress for the docker stack ?