Switch to signed integers for all identifiers

citusdata / pg_shard

ATTENTION: pg_shard is superseded by Citus, its more powerful replacement

https://github.com/citusdata/citus

GNU Lesser General Public License v3.0

1.06k stars 63 forks source link

Closed jasonmp85 closed 9 years ago

jasonmp85 commented 9 years ago

PostgreSQL doesn't have unsigned types, so using them when storing a value in a table doesn't make sense.

jasonmp85 commented 9 years ago

Assigning to @sumedhpathak, since we discussed this a bit in #110…

jasonmp85 commented 9 years ago

Reassigning to @onderkalaci because @sumedhpathak oversubscription, etc.

@onderkalaci can you look at this? It's pretty simple.

onderkalaci commented 9 years ago

@jasonmp85 I looked at the changes. All look fine.

I ran regression tests
Checked if this changes could lead to any problems (ie: signed-unsigned comparison problems). But, all changes look safe.
I searched for other uint* usage. I see no other PostgreSQL related variable.

We can :shipit: . I let you merge whenever you want to merge.