search

citusdata / pg_shard

ATTENTION: pg_shard is superseded by Citus, its more powerful replacement
https://github.com/citusdata/citus
GNU Lesser General Public License v3.0
1.06k stars 63 forks source link

Add more warnings to build #144

Closed jasonmp85 closed 8 years ago

jasonmp85 commented 8 years ago

I had an old TODO item to look into other possibly-useful compiler warnings to add to the project. This adds two such warning flags, one of which is fairly broad: -Wshadow and -Wconversion.

-Wshadow warns if one variable shadows one with a greater scope, and -Wconversion warns for all number of potentially unintended implicit conversions (between 32- and 64-bith precision, between real and integer, between signed and unsigned, truncation, etc.)

Note: do not merge this, I've opened it against a non-develop branch in order to get a cleaner diff (the hash token code is what finally pushed me to look into conversion warnings).

jasonmp85 commented 8 years ago

Closing since the base PR is now closed.