citusdata / pg_shard

ATTENTION: pg_shard is superseded by Citus, its more powerful replacement
https://github.com/citusdata/citus
GNU Lesser General Public License v3.0
1.06k stars 63 forks source link

Improve unsupported feature identification - Subqueries, CTEs and Functions #51

Closed onderkalaci closed 9 years ago

onderkalaci commented 9 years ago

Hey @jasonmp85 ,

fixes #14 fixes #46

Review tasks:

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.02%) when pulling ad4f92da7d94e5c9e29378b50cc0735a63d3b30d on feature-issue#14 into f1490b4c4fac84010eaf0d73b10e08d74c26ee1b on develop.

jasonmp85 commented 9 years ago

Looking over these changes there's very little you need to do before shipping this. Because you're touching all the error messages I've given feedback about those, but other than that, looks good.

As far as functions go, they can appear within the FROM clause, either returning single values, a series, or sets of records (a "function scan"). We don't currently support any of these cases (in fact if we find one I'd be surprised if there weren't also a join node somewhere), so the check you've added is correct. If they appear elsewhere (SELECT, WHERE) the query can be planned and executed, with some caveats (#47).

So address the three checkboxes I've added up top and :shipit:!

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.02%) when pulling 0186784638d7ab89bf9d1b62a0f1282af1b6d5b0 on feature-issue#14 into c56862e84d055d8c7d4f19c74c1c7dc9664735b6 on develop.