Closed onderkalaci closed 9 years ago
Looking over these changes there's very little you need to do before shipping this. Because you're touching all the error messages I've given feedback about those, but other than that, looks good.
As far as functions go, they can appear within the FROM
clause, either returning single values, a series, or sets of records (a "function scan"). We don't currently support any of these cases (in fact if we find one I'd be surprised if there weren't also a join node somewhere), so the check you've added is correct. If they appear elsewhere (SELECT
, WHERE
) the query can be planned and executed, with some caveats (#47).
So address the three checkboxes I've added up top and :shipit:!
Hey @jasonmp85 ,
fixes #14 fixes #46
Review tasks: