search

citusdata / pg_shard

ATTENTION: pg_shard is superseded by Citus, its more powerful replacement
https://github.com/citusdata/citus
GNU Lesser General Public License v3.0
1.06k stars 63 forks source link

Add PGXN metadata #71

Closed jasonmp85 closed 9 years ago

jasonmp85 commented 9 years ago

So we can upload this package to PGXN.

resolves #67

pykello commented 9 years ago

This looks good and matches the specification for the most part. The only thing that is a bit different from the examples in spec is the name/email pairs. The examples in spec suggest something like "Jason Petersen <jason@citusdata.com>" instead of "\"Jason Petersen\" <jason@citusdata.com>".

I don't have comments on the other parts, and I think this can be merged.

jasonmp85 commented 9 years ago

@pykello I looked at the relevant RFCs for email addresses, and they require quotes around the name part of an address if it has any whitespace characters. Because these RFCs are very hard to read and fairly obscure, it didn't surprise me their example was wrong. But for best compliance we want the quotes.