search

citusdata / postgresql-hll

PostgreSQL extension adding HyperLogLog data structures as a native data type
http://blog.aggregateknowledge.com/2013/02/04/open-source-release-postgresql-hll/
Apache License 2.0
1.13k stars 116 forks source link

Fix compatibility with PG16 #148

Closed df7cb closed 1 year ago

df7cb commented 1 year ago

PG16 ships its own get_extension_schema function, use that. stringToQualifiedNameList grew and extra argument for error reporting that can be set to NULL.

Close #146.

df7cb commented 1 year ago

We can't trivially drop stringToQualifiedNameList since it does additional processing of the string. It might be possible to do it, but I tried and got some regression diffs in disable_hashagg.sql. Possibly just a matter of switching representations of the same thing, but I don't have time to investigate that now.

Perhaps merge this first and worry about that optimization in a followup PR?

emelsimsek commented 1 year ago

Yes, I can see the regress failures. Looks like we need to use stringToQualifiedNameList.

@df7cb Are you able to merge? Or should I do it?

lizhiygu commented 1 year ago

Hello, when could we expect this patch to be merged? Thanks!