PostgreSQL 16 support

[devrimgunduz]

Hi,

HLL fails to build against v16. v16 is due next week. Can you please take a look ASAP?

Thanks! Devrim

/usr/lib64/ccache/clang -xc++ -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Xclang -no-opaque-pointers -O2 -fPIC -Wall -Wextra -Werror -Wno-unused-parameter -Wno-implicit-fallthrough -Iinclude -I/usr/pgsql-16/include -I. -I./ -I/usr/pgsql-16/include/server -I/usr/pgsql-16/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include -flto=thin -emit-llvm -c -o src/MurmurHash3.bc src/MurmurHash3.cpp src/hll.c:145:12: error: static declaration of 'get_extension_schema' follows non-static declaration 145 | static Oid get_extension_schema(Oid ext_oid); | ^~~~~~~~ In file included from src/hll.c:40: /usr/pgsql-16/include/server/commands/extension.h:50:17: note: previous declaration of 'get_extension_schema' with type 'Oid(Oid)' {aka 'unsigned int(unsigned int)'} 50 | extern Oid get_extension_schema(Oid ext_oid); | ^~~~~~~~ src/hll.c: In function 'FunctionOid': src/hll.c:326:43: error: too few arguments to function 'stringToQualifiedNameList' 326 | List qualifiedFunctionNameList = stringToQualifiedNameList(qualifiedFunctionName); | ^~~~~~~~~ In file included from src/hll.c:53: /usr/pgsql-16/include/server/utils/regproc.h:28:14: note: declared here 28 | extern List stringToQualifiedNameList(const char string, Node escontext); | ^~~~~~~~~ make[1]: [: src/hll.o] Error 1 make[1]: Waiting for unfinished jobs.... src/hll.c:145:12: error: static declaration of 'get_extension_schema' follows non-static declaration static Oid get_extension_schema(Oid ext_oid); ^ /usr/pgsql-16/include/server/commands/extension.h:50:12: note: previous declaration is here extern Oid get_extension_schema(Oid ext_oid); ^ src/hll.c:267:1: error: static declaration of 'get_extension_schema' follows non-static declaration get_extension_schema(Oid ext_oid) ^ /usr/pgsql-16/include/server/commands/extension.h:50:12: note: previous declaration is here extern Oid get_extension_schema(Oid ext_oid); ^ src/hll.c:326:83: error: too few arguments to function call, expected 2, have 1 List *qualifiedFunctionNameList = stringToQualifiedNameList(qualifiedFunctionName);

/usr/pgsql-16/include/server/utils/regproc.h:28:14: note: 'stringToQualifiedNameList' declared here
extern List *stringToQualifiedNameList(const char *string, Node *escontext);
^
3 errors generated.

[devrimgunduz]

ping

[devrimgunduz]

cough :)

[emelsimsek]

@devrimgunduz The latest release comes with the PostgreSQL Support. https://github.com/citusdata/postgresql-hll/releases/tag/v2.18

[devrimgunduz]

Thanks!