Closed aykut-bozkurt closed 2 years ago
Overall great PR, a few more notes in addition to the comments:
- Can you mirror the azure deployment template changes to the hammerdb deployment template as well.
I do that in Fabric upgrade PR.
I have added many contrib modules and made pg_regress use existing database instead of a recreated one. Last commit should be tested on CI to see module tests runnig properly. (Locally tested)
Future works:
Automate extension testing so that we can run extensions' regression tests with Citus installed and created as extension. We aim to see if Citus behaves properly for extensions' features. We use pg_regress underneath to see if any extension test fails because of Citus.
Current Workflow:
We provision single citus node on Azure to run those tests. We actually do not need Azure node but it is created because I wanted to reuse some part of the fab scripts to install postgres, citus.