search

citusdata / test-automation

Tools for making our tests easier to run
14 stars 5 forks source link

CircleCI to Github Migration #274

Closed gokhangulbiz closed 11 months ago

gurkanindibay commented 1 year ago

Branch triggers are seperated by branch prefixes. Are the added pipelines totally isolated so that other tests does not run when a push committed for one? @aykut-bozkurt do you have any idea? Additionally, we need to see the results as well. Could you add links for successful execution for each pipeline?

gokhangulbiz commented 1 year ago

Branch triggers are seperated by branch prefixes. Are the added pipelines totally isolated so that other tests does not run when a push committed for one? @aykut-bozkurt do you have any idea?

Here is an example workflow run for tpch tests: https://github.com/citusdata/test-automation/actions/runs/6795655949 Based on this we can say they're totally isolated.

Additionally, we need to see the results as well. Could you add links for successful execution for each pipeline?

I believe workflow outputs include a link to the pushed repository, similar to what we have in CircleCI. https://github.com/citusdata/test-automation/actions/runs/6795655949/job/18474146284#step:7:1206

gurkanindibay commented 1 year ago

Well done @gokhangulbiz . I like the style you design each pipeline. Can I see successful executions for these pipelines? Since they are designed to triggered by branch patterns, they are not triggered so I can not see the executions here. Additionally, we need to add trigger mechanism somewhere in the Readme to make the developers understand the trigger structure

gokhangulbiz commented 1 year ago

Can I see successful executions for these pipelines?

Extension Tests : https://github.com/citusdata/test-automation/actions/runs/6860289670 JDBC Tests: https://github.com/citusdata/test-automation/actions/runs/6860283899 PGBench Tests: https://github.com/citusdata/test-automation/actions/runs/6860279431 Scale Tests: https://github.com/citusdata/test-automation/actions/runs/6860267307 TPCH Tests: https://github.com/citusdata/test-automation/actions/runs/6795655949

Additionally, we need to add trigger mechanism somewhere in the Readme to make the developers understand the trigger structure

We have the similar trigger mechanism in GHA as documented in readme.md Also, I updated the documentation for minor naming changes in 731e4c1