search

city41 / rotary-bobble

Puzzle Bobble with rotary controls
https://rotary-bobble.mattgreer.dev/
GNU General Public License v3.0
3 stars 0 forks source link

The high score and gameplay patches have duplicate code #9

Closed city41 closed 9 months ago

city41 commented 9 months ago

Extract the common rotary decoding into a subroutine.

patchProm will need to support just adding an arbitrary subroutine without any jumping.

The rotary subroutine will need to use BIOS_PLAYER_MOD1/2 to determine who it's reading/updating

city41 commented 9 months ago

Won't fix. It just doesn't really matter.

city41 commented 9 months ago

I ended up doing this after all as the rotary controls ended up being used in four places