search

citycoins / ui

Basic UI components for interacting with the CityCoin contract. Requires Stacks Wallet for Web.
https://minecitycoins.com
GNU General Public License v3.0
28 stars 13 forks source link

Added optional text to the loading spinner #107

Closed abdullahranginwala closed 2 years ago

abdullahranginwala commented 2 years ago

https://github.com/citycoins/citycoin-ui/issues/97#issue-1046771712

Based on the feature suggested by @whoabuddy, optional text has been added to the loading spinner.

whoabuddy commented 2 years ago

Also, if you're in the CityCoins Discord we can chat about any of this in the #user-interface channel, I have the same user name there and I'm happy to help!

https://discord.gg/citycoins

whoabuddy commented 2 years ago

This looks great, last bit before merge, can you update the activation/RegisterUser.js component to use this at the bottom?

abdullahranginwala commented 2 years ago

@whoabuddy can you review the latest commit?

whoabuddy commented 2 years ago

Everything looks great, I did notice one small thing - on certain pages where the spinner is used in a box (like on the activation page) the spinner loads left-justified and the content loads centered. I'll bet it has something to do with the CSS inheritance but overall a non-issue as loading in general could be improved (lots of spinners!).