search

cityenergyproject / seattle

Energy benchmarking for Seattle
ISC License
1 stars 5 forks source link

Fix print on Microsoft Edge #155

Closed ebrelsford closed 2 years ago

ebrelsford commented 4 years ago

It doesn't look very good right now, part of that is some simple CSS, part of it is that Edge won't print background colors.

ebrelsford commented 4 years ago

This has been greatly improved in that the majority of the elements now appear in print on Edge. The biggest remaining issue is that Edge will not print background colors. For the most part this is okay, but you should see some of the issues in this PDF made with Edge.

seattle-benchmarking commented 4 years ago

@ebrelsford Thanks - this looks much better. I'm seeing a lot of issues with the GHG bubble chart too - and the fuel vs GHG bar charts seem to never display. Is there anyway to show an error message when they print with Edge to encourage using a different browser? similar to what we do with mobile - i think we tell them they should use a desktop. Or is it possible to hide the whole GHG section for Edge?

ebrelsford commented 4 years ago

@seattle-benchmarking What looks wrong on the GHG bubble chart? I'm looking at it in Edge and it looks fine.

I'm still working on the bar chart in fuel use and emissions as part of #148.

I'm not convinced the printing on Edge is bad enough that we should recommend a different browser.

seattle-benchmarking commented 4 years ago

image

seattle-benchmarking commented 4 years ago

When I print to PDF in Edge i see these lines across the bubbles

ebrelsford commented 4 years ago

Thanks for that @seattle-benchmarking, here's what I'm seeing when printing to PDF in Edge:

image

Would you mind sharing the settings you used? And which version of Edge you're using?

ebrelsford commented 4 years ago

The bar charts should appear now when printing in Edge. On my test machine this looks pretty good--let me know how it works for you @seattle-benchmarking ?