search

citygml4j / citygml-tools

Collection of tools for processing CityGML files
Apache License 2.0
115 stars 18 forks source link

Use CityGML default values for X3DMaterial properties when converting to CityJSON #24

Closed clausnagel closed 2 years ago

clausnagel commented 2 years ago

CityGML defines default values for the properties of X3DMaterial features like diffuseColor or shininess. If the properties are not present in a CityGML dataset, the to-cityjson operation does not create the properties for the CityJSON "X3DMaterial" object. However, CityJSON does not define default values for these properties. Therefore, the to-cityjson operation should not omit them if they are missing but rather create the properties and assign the CityGML default values. See also https://github.com/cityjson/specs/issues/90.

clausnagel commented 2 years ago

Added new --[no-]material-defaults option to the to-cityjson command to control whether CityGML default values for X3D materials should be used in the CityJSON output (0e2208fedf7fb4317742031acafb10a99561885c).