search

citygml4j / citygml-tools

Collection of tools for processing CityGML files
Apache License 2.0
115 stars 18 forks source link

citygml-tools create WaterClosureSurfaces out of nowhere #54

Closed MughtyWinky closed 1 month ago

MughtyWinky commented 1 month ago

While converting a CityGML document, which only includes buildings, citygml-tools creates WaterClosureSurfaces onto WallSurfaces.

The following picture shows the original and converted data.

image

Link to Dataset, tested on LoD2_Bergen-Enkheim.gml

clausnagel commented 1 month ago

Thanks for reporting. I fixed the bug with https://github.com/citygml4j/citygml4j/commit/1be3d9a156cd6022dcdf9d74d7c9894617355c4a.

Until a bugfix release is available, you can either build citygml-tools from source following this guide or use the edge Docker image from here.

MughtyWinky commented 1 month ago

Thanks for the quick response. Build it by myself using

git clone https://github.com/citygml4j/citygml-tools.git
cd citygml-tools
gradlew installDist
cd build
cd install
cd citygml-tools
copy c:\temp\LoD2_Bergen-Enkheim.gml .\
.\citygml-tools.bat to-cityjson LoD2_Bergen-Enkheim.gml

but the WaterClosureSurfaces are still present.

clausnagel commented 1 month ago

Sorry, my bad. One other commit was missing. Please git pull your local copy and rebuild.

MughtyWinky commented 1 month ago

Works fine now. Many thanks!