citygram / citygram-services

Web content transformation proxies for open data API's
https://citygram-services.herokuapp.com/
16 stars 37 forks source link

Integration of rubocop? #76

Open jszwedko opened 6 years ago

jszwedko commented 6 years ago

Hey!

I was wondering what the opinion of integrating Rubocop for style-checking would be. In addition to enforcing a consistent style, it also helps find issues like unused variables, improper equality operators, missing documentation, and other possible bugs.

Figured I'd ask before integrating it since it'll take a little time to address the issues that rubocop cannot autocorrect.

scottelundgren commented 6 years ago

I have no complaints about adding rubicop

bigfleet commented 6 years ago

@jszwedko I am a rubocop fan, and if you create a feature branch, I can take a look at fixing some of those items as well. Whenever a submission comes in that doesn't validate against, that can be part of the evaluation process at that time.