After upgrade to 3.0.0, histogram query selection doesn't work.

mrdavidlaing commented 10 years ago

Consider http://kibana.cityindex.logsearch.io/index.html#/dashboard/elasticsearch/IP%20Diagnostics%20-%20LIVE

Edit one of the histograms, and attempt to make it plot a "selected" query. Each time you click on a query, you get the error below in the console:

TypeError: Cannot call method 'push' of undefined
    at Function.a.mixin.toggleInOut (http://kibana.cityindex.logsearch.io/app/app.js:7:24817)
    at http://kibana.cityindex.logsearch.io/app/app.js:8:29352
    at http://kibana.cityindex.logsearch.io/app/app.js:8:27839
    at http://kibana.cityindex.logsearch.io/app/app.js:8:27351
    at http://kibana.cityindex.logsearch.io/app/app.js:10:7778
    at Object.f.$eval (http://kibana.cityindex.logsearch.io/app/app.js:9:6963)
    at Object.f.$apply (http://kibana.cityindex.logsearch.io/app/app.js:9:7070)
    at HTMLSpanElement.<anonymous> (http://kibana.cityindex.logsearch.io/app/app.js:10:7760)
    at HTMLSpanElement.$.event.dispatch (http://kibana.cityindex.logsearch.io/app/app.js:5:5617)
    at HTMLSpanElement.g.handle.h (http://kibana.cityindex.logsearch.io/app/app.js:5:1588) app.js:8
(anonymous function) app.js:8
(anonymous function) app.js:8
f.$apply app.js:9
(anonymous function) app.js:10
$.event.dispatch app.js:5
g.handle.h app.js:5

mrdavidlaing commented 10 years ago

Interestingly this only appears to be the case in "old" dashboards. New dashboards (eg, http://kibana.cityindex.logsearch.io/#/dashboard/file/logstash.json) don't have this problem...

mrdavidlaing commented 10 years ago

Deleting and re-adding this histogram panel fixes the problem on existing dashboards...

sopel commented 10 years ago

Have you tried saving the old dashboards again, sounds like it might fix the issue in fact by updating the underlying storage format changes (a commonly encountered pattern - of course, it might also break things ...)?

sopel commented 10 years ago

Ah, overlapping comments - a more specific solution, but a solution nonetheless :)

mrdavidlaing commented 10 years ago

Ok, I've pinned down the exact cause.

Old histogram panels store information about selected queries as an array:

"queries":[]

whilst new histogram panels store it as an object

"queries": {
  "mode": "all",
  "ids": []
}

So, the question is, why aren't old dashboards being automatically updated to the new format...

mrdavidlaing commented 10 years ago

Using http://kibana-pr4.monitor-cloud.cityindextest5.co.uk I've gone through all the dashboards; updating and re saving.

Let me know if I've missed any.

cityindex / kibana

After upgrade to 3.0.0, histogram query selection doesn't work. #2