search

cityjson / cityjson-threejs-loader

Apache License 2.0
19 stars 10 forks source link

Support recent versions of THREE #12

Open sguimmara opened 5 months ago

sguimmara commented 5 months ago

Recent version of THREE.js have some breaking changes that impact this loader. Here is a short list of changes that might be of interest in cityjson-threejs-loader:

liberostelios commented 5 months ago

Hi @sguimmara.

Thank you so much for reporting this 🙌 And apologies for the late response.

Indeed, the library is now breaking with recent versions of three.js. I have them in my radar and planning on addressing them soon.

liberostelios commented 5 months ago

@sguimmara

de6628b30b6c9cca6fdfad11469a4d7ffe17dfa0 is addressing the issue regarding changes in colorspace management. Therefore the library is now expected to work with v165.

I have not spotted any issues with the the other two issues: light changes should affect the setup of the renderer and scene on the client side, rather than this library. Am I missing something? Any suggestions?

sguimmara commented 4 months ago

For the color space change, you might want to check that colors set on the materials generated by the library look the same before and after the upgrade. If they don't, it means that their color space is not correct. We had this issue when working with Giro3D