search

cityjson / cityjson-threejs-loader

Apache License 2.0
16 stars 9 forks source link

How to integrate cityjson-threejs-loader with angular 14 #7

Closed moniruzzamanrony closed 11 months ago

moniruzzamanrony commented 1 year ago

Hi, I'm trying to use cityjson-threejs-loader in Angular 14 app.I'm trying to add cityjson-threejs-loader via the NPM package installer using, npm install git+https://github.com/cityjson/cityjson-threejs-loader.git

your package was added to my node_modules but isn't working. Here,

    const parser = new CityJSONWorkerParser();
    const loader = new CityJSONLoader(parser); //Got error:  TS2554: Expected 0 arguments, but got 1.
    loader.load("/assets/cityjsons/cube.city.json");

    this.scene.add(loader.scene);

Could you help me, how can I integrate cityjson-threejs-loader with angular 14.

Thanks.

imtiazShakil commented 1 year ago

Hi,

I've a made a pull request which fixes Angular Integration. Can you please review & merge it if possible. @liberostelios or @Ylannl

Thanks.

moniruzzamanrony commented 1 year ago

Hi, I have seen your latest implementation for the latest Angular. That is truly amazing. Hopefully, the new release will be more convenient for Angular integration with this library.

We're waiting for a new release. Thanks.    

liberostelios commented 11 months ago

@imtiazShakil @moniruzzamanrony Has #8 addressed your concern? Should we close this issue?

moniruzzamanrony commented 11 months ago

Yeah, addressed. Thanks @liberostelios @imtiazShakil . We should close this issue and publish the latest version in the NPM registry as soon as possible so that everyone has the fix.

Thanks.