search

cityjson / cjio

CityJSON/io: Python CLI to process and manipulate CityJSON files
MIT License
119 stars 31 forks source link

Add building_semantics command #179

Closed Yarroudh closed 10 months ago

Yarroudh commented 10 months ago

Hello, I added a new command to cjio named building_semantics that handles semantics for buildings in CityJSON files. The idea is to add semantic surfaces if they don't exist by calculating the normal vector of each surface. I tested the command locally and it works very fine. Can you please review my contribution and merge it if found helpful? Thanks

hugoledoux commented 9 months ago

Why did you close the PR?

Yarroudh commented 9 months ago

Hello @hugoledoux , I closed the PR as the command worked very fine on 3dfier results but not on GeoFlow LoD1.3 and LoD2.2 models. I added triangulation to the process to calculate the normals of planar triangles and not worry about the orientation of vertices (clockwise or counter-clockwise). I am investigating the solution and working on the code locally. Once completed I will make a new PR.