cityjson / cjio

CityJSON/io: Python CLI to process and manipulate CityJSON files
MIT License
126 stars 32 forks source link

when upgrade is used between 1.0 to 2.0 it doesn't change LOD's to string type #189

Open Lkeurentjes opened 2 months ago

Lkeurentjes commented 2 months ago

When upgrading from v1.0 to 2.0 using cjio [file] upgrade save [file] (using cjio v0.9.0; supports CityJSON v2.0), with for example these files: 601_SM_Solids.city.json 601_1_SM_solids.city.json

it doesn't change the lods from the geometries to strings making the schema validation report that the file is invalid.

balazsdukai commented 1 month ago

Hi @Lkeurentjes , I could not reproduce the issue with cjio v0.9.0 and neither on the develop branch. I tried both files, using the command as you wrote it. Then validate with cjval, plus I inspected the output files and the lod-s came out as strings from the upgrade. Could you check it again and confirm that the issue is present?