search

cityjson / specs

Specifications for CityJSON, a JSON-based encoding for 3D city models
https://cityjson.org
Creative Commons Zero v1.0 Universal
108 stars 25 forks source link

Building "address" is a JSON object but Metadata "address" is string. #149

Closed balazsdukai closed 1 year ago

balazsdukai commented 2 years ago

"A City Object of type "Building", "BuildingPart" or "BuildingUnit" may have a member "address", consisting of an array of JSON objects listing one or more addresses of that building (an apartment building could contain several for instance). The properties of an address JSON object are free format, to accommodate the different ways addresses are described in different countries."

But the metadata.pointOfContact may have one member with the name "address". The value is a string with the full address.

Shouldn't we harmonize?

hugoledoux commented 2 years ago

But aren't they already harmonised since both free format? I am not sure I follow you here.

hugoledoux commented 2 years ago

Only the snippet I left the old xAL properties, I guess you meant that? Should we use the same properties as in the metadata you mean?

balazsdukai commented 2 years ago

I meant that the Bulding address has a value of JSON object, while the metadata address is a JSON string*. I think both should have the same value type, either string or object.

hugoledoux commented 2 years ago

oh right I see now, stupid me...

We I think that would be too much of a break for a patch, no? But yes it should be harmonised, good point.

balazsdukai commented 2 years ago

Yes, that's true. Let's keep this open for the next minor (or major) release. Related to https://github.com/cityjson/specs/discussions/137

hugoledoux commented 1 year ago

@balazsdukai I guess here the best would be to put metadata/pointOfContact as a json object, agreed?

balazsdukai commented 1 year ago

Agreed.