search

cityjson / specs

Specifications for CityJSON, a JSON-based encoding for 3D city models
https://cityjson.org
Creative Commons Zero v1.0 Universal
107 stars 25 forks source link

Remove fixed references from CityObjectGroup property in metadata #76

Closed liberostelios closed 3 years ago

liberostelios commented 3 years ago

There is no need to aggregate objects at this level, so it is removed for now.

There are still some fixed names at the metadata level but I am not sure what's the best way to deal with them now so I'll leave it as it it.

hugoledoux commented 3 years ago

But did you test it? there were several places where it created issues: thematicModels and cityfeatureMetadata among others.

There are still some fixed names at the metadata level but I am not sure what's the best way to deal with them now so I'll leave it as it it.

What? We need to fix this. Now as it stands metadata is breaking the validity of CityJSON, this just cannot be.

hugoledoux commented 3 years ago

this fixes most issues I believe: https://github.com/cityjson/specs/commit/0ceeb31ee18da4cd84e00835ca98c6d96e8f726e

and makes the metadata schema less restrictive