search

cityjson / website

Source code for https://cityjson.org
MIT License
3 stars 9 forks source link

Fix location of `semantics` in spec example. #15

Closed zoelandia closed 10 months ago

zoelandia commented 10 months ago

semantics is defined at the Geometry level, not the CityObject level as the example shows.

hugoledoux commented 10 months ago

semantics is for each geometry object, no the city object.

I am not sure I follow here what you mean, can you elaborate?

And the specs are written in markdown there, we don't edit the html directly: https://github.com/cityjson/specs/blob/main/specs/specs.bs

zoelandia commented 10 months ago

Ah, thanks for the link to the md file—much easier to edit/diff there! I created a new PR: https://github.com/cityjson/specs/pull/185

What I mean is that the example JSON is making semantics a field in the city object, based on the current brackets. I'm trying to fix it so that semantics is appropriately a field within the geometry object.

zoelandia commented 10 months ago

Closing this PR now in favor of the other one!