citymania-org / grf-py

A Python framework for making NewGRFs for OpenTTD
GNU General Public License v2.0
14 stars 3 forks source link

(actions) support long (>=0xff) station ids #29

Closed ahyangyi closed 3 months ago

ahyangyi commented 4 months ago

Station IDs can be larger than 0xff and can use the extended format as well now.

Someday we might need a LONG_ID_FEATURES instead of VEHICLE_FEATURES to do this kind of test. However, I grepped the current occurrences of VEHICLE_FEATURES and apparently this is the only place where we need LONG_ID_FEATURES. The other places involving VEHICLE_FEATURES are about strings, where stations use action 0 strings or C4xx/C5xx instead.

So, considering that it is the only occurrence I find a need to modify, I’m being conservative and just add the clause I need at this moment.