search

citynetwork / markdown-xblock

An XBlock enabling Open edX course authors to maintain content in Markdown.
GNU Affero General Public License v3.0
3 stars 3 forks source link

Add some CSS to tables #26

Closed mrtmm closed 2 years ago

mrtmm commented 2 years ago

When using the "tables" extra feature (enabled by default) tables are created perfectly fine but no styling is added to the tables by default.

While the tables can be styled/themed via theme/brand setups as they are, not everyone using this XBlock may have access to these settings.

Add some CSS to match the tables to the current raw-HTML XBlock tables to create a better and more cohesive user experience.

mrtmm commented 2 years ago

@fghaas the fact the we currently add no styling to tables whatsoever appears to look like tables are "broken". https://github.com/citynetwork/markdown-xblock/issues/22 https://discuss.openedx.org/t/markdown-plugin-table-bug/6972 I figured we could default to make it look like the tables in the HTML block. Of course anyone could still override it via theme/brand. What do you think?

fghaas commented 2 years ago

This looks good to me but I have no bandwidth to test this right now so I'll trust your judgment. :) If you say this is good, I'll approve and merge.

mrtmm commented 2 years ago

I've tested it locally and I believe it's good to merge, we can ask on the forum for user feedback also, I believe this will be helpful for them.