citynetwork / markdown-xblock

An XBlock enabling Open edX course authors to maintain content in Markdown.
GNU Affero General Public License v3.0
3 stars 3 forks source link

Add support for public courses #31

Closed mrtmm closed 2 years ago

mrtmm commented 2 years ago

This XBlock is meant for creating text content in courses and there is no reason it should be limited to enrolled students only when course authors choose to make their course public.

Add implemention for the public_view to allow using this XBlock in public courses.

mrtmm commented 2 years ago

@fghaas this came up in the forum, I suggest we add support for public courses, no rush on review, thanks!

fghaas commented 2 years ago

Huh! I didn't even know this feature existed.

mrtmm commented 2 years ago

Huh! I didn't even know this feature existed.

Same. Just discovered it when looking into this :) For completeness sake, to test it/use it, one has to add a waffle flag: seo.enable_anonymous_courseware_access on their platform and set Course Visibility For Unenrolled Learners to public in course advanced settings.

Looks good to me! Should we cut 1.2.0 from this?

Yes, that sounds good, thanks!

fghaas commented 2 years ago

Done (#32). The PyPI package is updated as well.

mrtmm commented 2 years ago

Cool, thanks!