cityofaustin / atd-dockless-dataviz

🛴 A map for exploring dockless mobility data.
http://dockless.austintexas.io/
Other
21 stars 5 forks source link

Color highlighting on clicked cell is broken #105

Closed mateoclarke closed 5 years ago

mateoclarke commented 5 years ago

With the new json layer of census tracts coming from the dockless-api instead of hexbins, the color highlighting feature is now broken...

Apr-30-2019 17-04-59

johnclary commented 5 years ago

@mateoclarke with the API switch to census tracts, polygons are now using GEOID10 instead of cell_id as their unique identifier.

So this block of code needs to be updated:

docklessMap.map.setFilter("feature_layer_highlight", [
  "==",
  "cell_id", # should be GEOID10 
  e.features[0].properties.cell_id
]);

....or should we update the API to once again return cell_id?

mateoclarke commented 5 years ago

@johnclary Yeah, that makes sense. We are planning to go back to having hexbins at one point in the near future, right? We just need to play around with sizing? If so, I think we should update the API side and leave the JS code as is.

johnclary commented 5 years ago

Agreed. Here's that issue: https://github.com/cityofaustin/atd-dockless-api/issues/52

johnclary commented 5 years ago

@mateoclarke API has been updated. this should be resolved.

mateoclarke commented 5 years ago

Yup!

Screen Shot 2019-05-07 at 12 01 15 PM