search

cityofaustin / atd-moped

A comprehensive mobility project tracking platform for Austin, Texas.
https://mobility.austin.gov/moped/
4 stars 3 forks source link

Added DeleteConfirmationModal to the work activity table #1390

Closed arkadeep closed 2 months ago

arkadeep commented 3 months ago

Hey @mddilley, thank you for your patience on this—the PR is ready for issue #18324 I tested it on my local setup, so I think everything is fine, but this being my first time writing any React code, there might be something wrong (hopefully not though).

Associated issues

Closes https://github.com/cityofaustin/atd-data-tech/issues/18324

Testing

URL to test:

https://deploy-preview-1390--atd-moped-main.netlify.app/

Steps to test:

  1. Delete a work activity row and see the updated delete confirmation modal matches the one in the funding table

Ship list

arkadeep commented 3 months ago

Hey @mddilley, I think I got everything. I was confused about the changes in the package-lock file. I hope I didn't break anything.

mddilley commented 3 months ago

Thanks @arkadeep - I left two last comments for changes, and then we can get this tied up! I also missed going over our code formatting helper called Prettier. I can push one last commit to run that formatter on this code, but I wanted to let you know about another tool we use on the team. No change needed by you.

All of this is so rad! Thank you again for all the work that you put into it! 🙌

arkadeep commented 2 months ago

@mddilley, thanks for all the input. I'm sorry for the package-lock mess up. I should have seen those changes. But I can assure you that it should be okay now!

mddilley commented 2 months ago

@arkadeep Thanks and no apologies needed. Seeing unexpected code changes when creating a pull request is all part of the fun! We see it happen all the time. Thanks for cleaning that up, and I'll approve this shortly.

Thank you again for diving into React! 🤿 🎉