Closed mddilley closed 2 months ago
@frankhereford It is always a good time for requested changes! Thanks for catching that, and I'm looking at it right now. 🙏
@frankhereford @johnclary Thanks for your reviews on this today! I pulled out the code for the Bike Share Station because it is feeling like a lot to me, and I'd rather focus on getting this FDU code shipped tomorrow. I'll target the other issue for a patch or the next release.
Just re-requested y'all's review 🙏
Associated issues
Closes https://github.com/cityofaustin/atd-data-tech/issues/18450
This PR adds two generated columns to pull the fund name out of the
fund
jsonb column and pull the fund, department, and unit values out of thefund
anddept_unit
jsonb columns. We may change the way this data is stored in the future so these fields will give us a way to expose this data consistently over time.Testing
URL to test:
Local only
Steps to test:
fund_dept_unit
orfund_name
arenull
.fund_name
now shows the value held in the json in thefund
column.fund_dept_unit
should still benull
since there isn't complete data to populate it.fund_name
andfund_dept_unit
have values now, and they should match the values in thefund
andunit
columns of the row.Ship list