Update more advanced search fields to use lookups with contains operator

chiaberry commented 2 months ago

Associated issues

https://github.com/cityofaustin/atd-data-tech/issues/18230

I removed some of the operators from the FiltersConfig and rearranged some to fix the default (first in list is default), but since I also refactored the Config from an array to an object, the diff is harder to follow.

Testing

URL to test:

https://deploy-preview-1406--atd-moped-main.netlify.app/moped/projects

Steps to test:

Test the advanced filters.

Inspectors, Designers, Types and Partners default to contains
Created By, Inspectors and Designers now have an autocomplete option using the users table
If a field has a lookup table and autocomplete option and the default operator is "is", the contains operator now gives a freesolo option. These are project lead, project sponsor, created by and public process status. dropping freesolo for now
Lead and Sponsor default to "is"
Because I refactored the Field Config, it is worth it to test out the chips again.

Ship list

[ ] Code reviewed
[ ] Product manager approved
[ ] Product manager checked DB view dependencies
[ ] Product manager added to QA test script if applicable

mddilley commented 2 months ago

@chiaberry I also ran into the issue that Rose described above. I'll hold off on review for now.

Also, thank you for tackling the config refactor!! It will be nice to get away from the array of fields shape that doesn't quite fit the way we handle the filters in the post-GraphQLAbstract code. 🙌

chiaberry commented 2 months ago

I'm so sorry guys that I asked for review and hadnt pushed up my last commit

Thanks for catching the default operator I missed updating @roseeichelmann , I am noticing now how the config is inconsistent with using that to define the default operator. I'll add that to the rest of the config entries.

As for the fresolo option, let's talk about it tomorrow, I can pull it into a helper function but I am not sure how we could convey to users that that option is there....

mddilley commented 2 months ago

@roseeichelmann thanks again for flagging how confusing the freeSolo option could be! I captured your feedback and discussion from dev sync last week in https://github.com/cityofaustin/atd-data-tech/issues/18934 so we can take another swing at it outside this PR. Re-requesting your review since Chia is out this morning.

mddilley commented 2 months ago

@tillyw just caught your comment - i will create an issue for that because it is also confusing to me to carry over a value from one search field to another unrelated one! 🙏

Edit: https://github.com/cityofaustin/atd-data-tech/issues/19051

cityofaustin / atd-moped