cityofaustin / atd-moped

A comprehensive mobility project tracking platform for Austin, Texas.
https://mobility.austin.gov/moped/
4 stars 3 forks source link

Improve error handling when consuming deprecated fields from url search parameters #1408

Closed mddilley closed 2 months ago

mddilley commented 2 months ago

Seeing this code again does make me realize that we could handle unknown search fields that we consume from the saved URLs better like if we renamed a field or updated one.

I'll create an issue. It could be cool to really lean into the nice error handling that you added, and throwing more specific errors.

Screenshot 2024-09-05 at 4 51 07 PM

vs. something like:

Screenshot 2024-09-05 at 4 49 15 PM

_Originally posted by @mddilley in https://github.com/cityofaustin/atd-moped/pull/1406#discussion_r1746200713_

mddilley commented 2 months ago

forgot that this wasn't going to appear in atd-data-tech when created from a PR comment. Closing!