cityofaustin / atd-vz-data

The technology that powers the City of Austin's Vision Zero program
https://visionzero.austin.gov/viewer/
11 stars 3 forks source link

[BUG] VZV: Missing "Other" modes crashes on the map #1421

Open mddilley opened 5 months ago

mddilley commented 5 months ago

Associated issues

Closes https://github.com/cityofaustin/atd-data-tech/issues/16528

This PR updates the crash map histogram to shows total fatalities and serious injuries instead of total crashes. This matches what we see in the dashboard By Travel Mode visualization, and also the figures shown in the popup that appears when you click on a crash location on the map.

Testing

URL to test: https://deploy-preview-1421--atd-vzv-staging.netlify.app/viewer/map

Steps to test:

  1. On the crash map, use filters: All, Other mode only, and the default date range
  2. When you hover the time of day histogram bars, you should see the numbers shown in parenthesis in the tooltips adding up to 5. This is the total fatalities and serious injuries of the 3 crashes shown on the map.
  3. Go to the production site and notice that the tooltips numbers total up to 3 crashes instead of the total of fatalities and serious injuries associated with those crashes.

Ship list

mddilley commented 5 months ago

@roseeichelmann thanks!, and I agree that it is worth thinking about ways to indicate exactly what is displayed in this viz. Getting oriented on what data was coming into the component and what is displayed wasn't super straightforward when i was working on this.

For the All button, I see exactly what you are saying. It does kind of imply "All Crashes with no filters" (neither) instead of "All crashes that have a fatality or serious injury" (both). I remembered that we changed this once before and found this PR that shows that we once had just the two buttons but we changed it because it was confusing. Not a lot of crumbs as to why it was considered confusing so I think it could use another look. That was a long time ago now!

Curious what @johnclary thinks too. Happy to keep iterating on this one!