search

cityofaustin / atd-vz-data

The technology that powers the City of Austin's Vision Zero program
https://visionzero.austin.gov/viewer/
11 stars 2 forks source link

Use `crash_timestamp` and `prsn_death_timestamp` columns #1477

Closed johnclary closed 1 month ago

johnclary commented 2 months ago

Associated issues

This ended up being a bit more of a lift than i was expecting, but the majority of this diff is just codegen and linting 😅

Testing

  1. Start your data model stack as usual and run the CRIS import ETL.
  2. Check that all of the VZE pages load and interact normally
  3. Pick a few crashes at random and compare the crash date you see locally versus in prod. They should match if you're testing from US/Central. Otherwise you will notice that the crash date is always rendered in local time. (That change is not specific to this PR, but I have fixed up the formatting of the timestamp strings).

  4. Query the people table and compare prsn_death_date and prsn_death_time to prsn_death_timestamp

    Ship list

    • [ ] Check migrations for any conflicts with latest migrations in master branch
    • [ ] Confirm Hasura role permissions for necessary access
    • [ ] Code reviewed
    • [ ] Product manager approved