Closed johnclary closed 3 weeks ago
i think the test instructions need to be updated to say $ ./socrata_export.py --crashes --people
?
also could update test instructions to say to run the hasura migrations/metadata in this branch
I didn't run it, but read through the code and left a question or two. I got tripped up with the compare_column_metadata script a bit, but nothing major I don't think.
👋 thanks for the feedback. i reworked the logging and added docstrings in socrata_export.py
and i refactored _compare_column_metadata.py
to be less confusing 👍
edit: and i fixed the bug in the crash list view that had minor injuries taking precedence over serious injuries
Associated issues
This is the new Socrata export! The diff is not as bad as it looks—I had to renumber a bunch of migrations.
These follow-up tasks will be addressed in separate issues/PRs:
Testing
You can run this using a local db, but we're going to use the test instance cluster since it is already loaded up with 10 years of data.
Setup
In our password store, locate the item called
Env file for the Vision Zero new data model Socrata export ETL
and save it in the root of this ETL directory as.env
.Build and run the Socrata export. This may take up to 20 minutes.